changeset 405:e221473a8217

comment cleanups and clarification
author Tassilo Philipp
date Wed, 07 Apr 2021 18:51:38 +0200
parents 524fdca405bf
children 351bb41d3bb1
files dyncallback/dyncall_callback.h dynload/dynload_unix.c
diffstat 2 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/dyncallback/dyncall_callback.h	Wed Apr 07 18:39:46 2021 +0200
+++ b/dyncallback/dyncall_callback.h	Wed Apr 07 18:51:38 2021 +0200
@@ -32,7 +32,7 @@
 
 typedef struct DCCallback DCCallback;
 
-// return value is the type encoded as a signature char (character of the set [vBcCsSiIjJlLfd]).
+/* return value is the type encoded as a type-specifying signature char (see dyncall_signature.h) */
 typedef char (DCCallbackHandler)(DCCallback* pcb, DCArgs* args, DCValue* result, void* userdata);
 
 #ifdef __cplusplus
--- a/dynload/dynload_unix.c	Wed Apr 07 18:39:46 2021 +0200
+++ b/dynload/dynload_unix.c	Wed Apr 07 18:51:38 2021 +0200
@@ -197,7 +197,8 @@
   if(lib == (void*)d->pLib) {
     l = dl_strlen_strcpy(d->sOut, info->dlpi_name, d->bufSize);
 
-    /* if dlpi_name is empty, lookup name via dladdr(proc_load_addr, ...) */
+    /* dlpi_name might be empty for the own process (d->pLib == NULL), so */
+    /* try lookup via dladdr(proc_load_addr, ...) */
     if(l == 0 && d->pLib == NULL) {
       /* dlpi_addr is the reloc base (0 if PIE), find real virtual load addr */
       void* vladdr = (void*)info->dlpi_addr;